Review request for JMC-6408: Cleanup of MBeanOperationsWrapper
Langer, Christoph
christoph.langer at sap.com
Wed Feb 13 14:20:28 UTC 2019
Hi Marcus,
looks good to me. Nice cleanup.
However, I'd suggest another order of arguments for MBeanOperationWrapper:: createOperations, like this:
static Collection<IOperation> createOperations(MBeanServerConnection connection , ObjectName objectName, MBeanOperationInfo[] operations)
this would match the order of arguments of the constructor of MBeanOperationWrapper.
Best regards
Christoph
> -----Original Message-----
> From: jmc-dev <jmc-dev-bounces at openjdk.java.net> On Behalf Of Marcus
> Hirt
> Sent: Mittwoch, 13. Februar 2019 10:10
> To: jmc-dev at openjdk.java.net
> Subject: Review request for JMC-6408: Cleanup of
> MBeanOperationsWrapper
>
> Hi all,
>
> Please review this fix to clean up the MBeanOperationsWrapper a bit
> (should not subclass ArrayList).
>
> Jira: https://bugs.openjdk.java.net/browse/JMC-6408
> Webrev: http://cr.openjdk.java.net/~hirt/JMC-6408/webrev.0/
>
> Kind regards,
> Marcus
>
More information about the jmc-dev
mailing list