Opinions

[Marcus Hirt]

At the same time it's annoying to get externalization warnings
for things that should never be externalized. That said,
I agree local project overrides should only be used when necessary, 
and perhaps this is not necessary. Also something can be said
for keeping the rules across all the projects the same, i.e. 
always use the macros or externalize.

For me it's a coin toss. Don't even remember who was annoyed at 
the macros in the test bundles anymore. ;)

Kind regards,
Marcus


On 2019-02-21, 17:06, "Mario Torre" <neugens at redhat.com> wrote:

    On Thu, 2019-02-21 at 15:49 +0100, Marcus Hirt wrote:
    > Hi all,
    > 
    > The tests are normally not locale dependent, and so should not
    > require externalization. Thus, it doesn’t make much sense to require
    > using the NON-NLS macros in pure test bundles. That said, changing
    > the error reporting for non-externalized strings for the test bundles
    > would require Eclipse project settings overrides for the test
    > bundles. But perhaps that is ok?
    > 
    > What do you say? Require use of NON-NLS in test bundles or not?
    
    I think it makes sense to have a global configuration rather than a per
    test one to ignore the localisation string.
    
    Cheers,
    Mario
    
    -- 
    Mario Torre
    Associate Manager, Software Engineering
    Red Hat GmbH <https://www.redhat.com>
    9704 A60C B4BE A8B8 0F30  9205 5D7E 4952 3F65 7898