Review Request: Fix 2018-09 Platform Definition

[Jie Kang]

On Thu, Jan 3, 2019 at 3:06 PM Marcus Hirt <marcus.hirt at oracle.com> wrote:
>
> I have a fix which fixes this as part of the upgrade to Eclipse 2018-12. Let me check how far along the Jakarta-approval is first.

Oh nice! I have also been doing some testing of JMC with Eclipse
2018-12. There is an issue with Wayland where the JMC charts are black
(tested on F29 Wayland GNOME Desktop). I will be trying to find the
root cause; it could be JMC needs an update in the chart library or it
could be something in the underlying Eclipse libraries (SWT maybe?).
This behaviour is not exhibited when using 2018-09 or Photon platform
definitions.  Is anyone possibly looking at this already?

I also read the bug for upgrading to 2018-12 [1] just now and just in
case, for org.eclipse.equinox.ds, the migration suggestion is to
replace it with org.apache.felix.scr [2]. I haven't come across any
issues doing this in manual user testing but of course that covers
very little...

[1] https://bugs.openjdk.java.net/projects/JMC/issues/JMC-6274
[2] https://git.eclipse.org/r/#/c/130458/1/bundles/org.eclipse.platform.doc.isv/porting/4.10/faq.html


Regards,

>
> Kind regards,
> Marcus
>
> - Excuse me if terse; sent from my phone.
>
> > On 3 Jan 2019, at 17:49, Jie Kang <jkang at redhat.com> wrote:
> >
> > On Thu, Jan 3, 2019 at 11:07 AM Prem Balakrishnan
> > <prem.balakrishnan at oracle.com> wrote:
> >>
> >> Hi Jie,
> >>
> >> Thank you for bringing this to our attention.
> >>
> >> We have checked in this optional platform in between our initial check-in and reverting process of new javamail upgrade patch.
> >>
> >> Request you to create a bug for the same and update the review thread.
> >
> > Hi Prem,
> >
> > Thanks for taking a look at this! I am not an Author so I can't create
> > bugs for JMC; I have asked Alex to create one for me and it's:
> > https://bugs.openjdk.java.net/projects/JMC/issues/JMC-6309
> >
> >
> > Regards,
> >
> >>
> >>
> >> Regards,
> >> Prem
> >>
> >> -----Original Message-----
> >> From: Jie Kang <jkang at redhat.com>
> >> Sent: Thursday, January 03, 2019 8:07 PM
> >> To: jmc-dev at openjdk.java.net
> >> Subject: Review Request: Fix 2018-09 Platform Definition
> >>
> >> Hi,
> >>
> >> The 2018-09 platform definition still references the new javamail and javax.activation packages. I believe the change to use those was reverted pending third-party approval. The following changes the
> >> 2018-09 definition to match the oxygen/photon definitions so JMC can build with the p2 site definition in releng/third-party. Thoughts?
> >>
> >> diff --git a/releng/platform-definitions/platform-definition-2018-09/platform-definition-2018-09.target
> >> b/releng/platform-definitions/platform-definition-2018-09/platform-definition-2018-09.target
> >> --- a/releng/platform-definitions/platform-definition-2018-09/platform-definition-2018-09.target
> >> +++ b/releng/platform-definitions/platform-definition-2018-09/platform-d
> >> +++ efinition-2018-09.target
> >> @@ -34,9 +34,11 @@
> >> <?pde version="3.8"?><target name="jmc-target-2018-09" sequenceNumber="47">
> >>     <locations>
> >>         <location includeAllPlatforms="false"
> >> includeConfigurePhase="true" includeMode="planner"
> >> includeSource="true" type="InstallableUnit">
> >> -            <unit id="com.sun.mail.jakarta.mail" version="1.6.3"/>
> >> -            <unit id="com.sun.activation.jakarta.activation" version="1.2.1"/>
> >> +            <unit id="javax.mail.api" version="1.4.0"/>
> >>             <unit id="javax.mail.dsn" version="1.4.0"/>
> >> +            <unit id="javax.mail.imap" version="1.4.0"/>
> >> +            <unit id="javax.mail.pop3" version="1.4.0"/>
> >> +            <unit id="javax.mail.smtp" version="1.4.0"/>
> >>             <unit id="org.owasp.encoder" version="1.2.1"/>
> >>             <unit id="org.twitter4j.core" version="4.0.6"/>
> >>             <repository location="http://localhost:8080/site"/>
> >>
> >>
> >> Regards,
>