Review request for JMC-6480: Fixing the GC Locker rule.

[Marcus Hirt]

Thanks Jie and Henrik for reviewing!

Kind regards,
Marcus

On Fri, May 24, 2019 at 12:57 PM Henrik Dafgård <hdafgard at gmail.com> wrote:

> This change looks good to me! I agree with the discussion on the
> JfrRuleBaseline, but that is probably for a later time.
>
>
> Regards,
> Henrik Dafgård
>
>
> On Wed, 22 May 2019 at 22:19, Marcus Hirt <marcus.hirt at datadoghq.com>
> wrote:
>
>> I think that is probably a result from the baseline being generated on
>> Windows this time. At some point we should make sure that it is done in a
>> platform independent manner.
>>
>> Kind regards,
>> Marcus
>>
>> On Wed, May 22, 2019 at 10:09 PM Jie Kang <jkang at redhat.com> wrote:
>>
>> > Hey Marcus,
>> >
>> > For
>> >
>> > ---
>> >
>> a/core/tests/org.openjdk.jmc.flightrecorder.rules.jdk.test/src/test/resources/baseline/JfrRuleBaseline.xml
>> > +++
>> >
>> b/core/tests/org.openjdk.jmc.flightrecorder.rules.jdk.test/src/test/resources/baseline/JfrRuleBaseline.xml
>> >
>> > it looks like the line endings of the whole file have been changed
>> > (from \n to \r\n); is that intentional?
>> >
>> > The patch looks good to me otherwise. Thanks for addressing my
>> suggestions!
>> >
>> >
>> > Cheers,
>> >
>> > On Wed, May 22, 2019 at 3:59 PM Marcus Hirt <marcus at hirt.se> wrote:
>> > >
>> > > Thanks Jie!
>> > >
>> > > Here is an updated version:
>> > > cr.openjdk.java.net/~hirt/JMC-6480/webrev.1/
>> > >
>> > > Kind regards,
>> > > Marcus
>> > >
>> > > -----Ursprungligt meddelande-----
>> > > Från: Jie Kang <jkang at redhat.com>
>> > > Skickat: den 22 maj 2019 15:01
>> > > Till: Marcus Hirt <marcus at hirt.se>
>> > > Kopia: jmc-dev at openjdk.java.net
>> > > Ämne: Re: Review request for JMC-6480: Fixing the GC Locker rule.
>> > >
>> > > Hi Marcus,
>> > >
>> > > Looks mostly good to me though I think the tests will need to be
>> > adjusted for the new text:
>> > > [ERROR]   TestRulesWithJfr.verifyAllResults:132->verifyRuleResults:159
>> > >
>> > > As well, I would like to suggest rephrasing of a portion of
>> > GcLockerRuleFactory_TEXT_INFO_LONG
>> > >
>> > > s/will need for the object/will need the object/
>> > >
>> > >
>> > > Regards,
>> > >
>> > >
>> > > On Tue, May 21, 2019 at 5:09 PM Marcus Hirt <marcus at hirt.se> wrote:
>> > > >
>> > > > Hi all,
>> > > >
>> > > > Please review this fix for the GC Locker rule.
>> > > >
>> > > > Jira:   https://bugs.openjdk.java.net/browse/JMC-6480
>> > > > Webrev: http://cr.openjdk.java.net/~hirt/JMC-6480/webrev.0/
>> > > >
>> > > > Kind regards,
>> > > > Marcus
>> > > >
>> > >
>> >
>>
>