RFR: 6875: Add agent MXBean operation to return instrumented xml configuration [v2]

[Marcus Hirt]

On Tue, 18 Aug 2020 18:27:30 GMT, Jessye Coleman-Shapiro <jescolem at openjdk.org> wrote:

>> This patch adds the MXBean operation `AgentControllerMXBean.retrieveEventProbes()` to the agent.  This function is the
>> counterpart of `AgentControllerMXBean.defineEventProbes()`.
>
> Jessye Coleman-Shapiro has updated the pull request with a new target base due to a merge or a rebase. The pull request
> now contains three commits:
>  - Add javadoc for retrieveCurrentTransforms
>  - Add test for invalid xml inputted
>  - create retrieveEventProbes() operation

Changes requested by hirt (Lead).

agent/src/main/java/org/openjdk/jmc/agent/jmx/AgentControllerMXBean.java line 39:

> 38:
> 39: 	public void defineEventProbes(String xmlDescription) throws Exception;
> 40:

Javadoc here explaining when exceptions are thrown (I assume when providing an invalid probe definition).

agent/src/test/java/org/openjdk/jmc/agent/test/TestRetrieveEventProbes.java line 75:

> 74: 	}
> 75:
> 76: 	public void test() {

Test here at least testing providing an invalid probe definition to the MBean, and ensuring that the appropriate effect
happens.

-------------

PR: https://git.openjdk.java.net/jmc/pull/99