RFR: 6875: Add agent MXBean operation to return instrumented xml configuration [v2]

Jessye Coleman-Shapiro jescolem at openjdk.java.net
Wed Aug 19 15:42:02 UTC 2020


On Tue, 18 Aug 2020 22:10:48 GMT, Marcus Hirt <hirt at openjdk.org> wrote:

>> Jessye Coleman-Shapiro has updated the pull request with a new target base due to a merge or a rebase. The pull request
>> now contains three commits:
>>  - Add javadoc for retrieveCurrentTransforms
>>  - Add test for invalid xml inputted
>>  - create retrieveEventProbes() operation
>
> agent/src/test/java/org/openjdk/jmc/agent/test/TestRetrieveEventProbes.java line 75:
> 
>> 74: 	}
>> 75:
>> 76: 	public void test() {
> 
> Test here at least testing providing an invalid probe definition to the MBean, and ensuring that the appropriate effect
> happens.

Test added in 80b5757

> agent/src/main/java/org/openjdk/jmc/agent/jmx/AgentControllerMXBean.java line 39:
> 
>> 38:
>> 39: 	public void defineEventProbes(String xmlDescription) throws Exception;
>> 40:
> 
> Javadoc here explaining when exceptions are thrown (I assume when providing an invalid probe definition).

Javadoc added in 80b5757

-------------

PR: https://git.openjdk.java.net/jmc/pull/99


More information about the jmc-dev mailing list