RFR: 7032: The banner is missing from help page

Suchita Chaturvedi schaturvedi at openjdk.java.net
Sat Dec 5 21:59:10 UTC 2020


On Fri, 4 Dec 2020 02:31:30 GMT, Marcus Hirt <hirt at openjdk.org> wrote:

>> It looks like the height of the banner picture, and the size reserved for the banner, mismatch:
>> <img width="1763" alt="image" src="https://user-images.githubusercontent.com/16906077/101113774-5f22e180-35e0-11eb-8521-52eeb354eea6.png">
>
> Also, we should ensure that the background color aligns with the color of the pixels to the right in the banner. Just cutting over to white looks very unprofessional on wide screens.

@thegreystone Thanks for the review. Please find below the screenshot from JMC 7.1.2 Somehow the image is missing in JMC 8 so I have just added the same. I haven't done any changes related to the height of the banner. But even I feel the white space between banner and content looks odd. So I think I can increase the height a bit. Regarding white space at right, I am not getting that in my screen and banner is taking complete space from left to right. Is there a way to test it somehow on my machine?

![image](https://user-images.githubusercontent.com/11155712/101266192-a50faf00-3772-11eb-8f23-eb71f3d8eb53.png)

-------------

PR: https://git.openjdk.java.net/jmc/pull/173


More information about the jmc-dev mailing list