RFR: 6787: Simplified stack trace tree model [v8]

Marcus Hirt hirt at openjdk.java.net
Fri Dec 11 10:40:57 UTC 2020


On Fri, 11 Dec 2020 07:58:07 GMT, Guru Hb <ghb at openjdk.org> wrote:

>> Alex Ciminian has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   6787: tolerate the UNKNOWN_FRAME type inside the flame graph
>
> core/org.openjdk.jmc.flightrecorder/src/main/java/org/openjdk/jmc/flightrecorder/stacktrace/tree/AggregatableFrame.java line 44:
> 
>> 42:  * Frame wrapper taking into account a frame separator for hash code and equals.
>> 43:  */
>> 44: public final class AggregatableFrame implements IMCFrame {
> 
> We already have the same Class name in "org.openjdk.jmc.flightrecorder.stacktrace.graph.AggregatableFrame.java" and both are identical. 
> Opt 1 : If we really need a seperate "tree.AggregatableFrame" , try to rename this class. 
> Opt 2 : If we can re-use "tree.AggregatableFrame" then this file is not required and might need to change this class and its package name in the current fix.
> 
> Ok, By looking the past comment, Is it possible to Consolidate in this fix Itself ? (If not then i can go ahead and approve this fix).

We agreed that we'd take it as is, since I'll be doing some cleanup in this area anyways. I'll be consolidating them as part of the changes to bring the stream toolkit into core.

-------------

PR: https://git.openjdk.java.net/jmc/pull/159


More information about the jmc-dev mailing list