RFR: 6787: Simplified stack trace tree model [v8]
Guru Hb
ghb at openjdk.java.net
Fri Dec 11 11:47:03 UTC 2020
On Fri, 11 Dec 2020 10:38:15 GMT, Marcus Hirt <hirt at openjdk.org> wrote:
>> core/org.openjdk.jmc.flightrecorder/src/main/java/org/openjdk/jmc/flightrecorder/stacktrace/tree/AggregatableFrame.java line 44:
>>
>>> 42: * Frame wrapper taking into account a frame separator for hash code and equals.
>>> 43: */
>>> 44: public final class AggregatableFrame implements IMCFrame {
>>
>> We already have the same Class name in "org.openjdk.jmc.flightrecorder.stacktrace.graph.AggregatableFrame.java" and both are identical.
>> Opt 1 : If we really need a seperate "tree.AggregatableFrame" , try to rename this class.
>> Opt 2 : If we can re-use "tree.AggregatableFrame" then this file is not required and might need to change this class and its package name in the current fix.
>>
>> Ok, By looking the past comment, Is it possible to Consolidate in this fix Itself ? (If not then i can go ahead and approve this fix).
>
> We agreed that we'd take it as is, since I'll be doing some cleanup in this area anyways. I'll be consolidating them as part of the changes to bring the stream toolkit into core.
ok.
-------------
PR: https://git.openjdk.java.net/jmc/pull/159
More information about the jmc-dev
mailing list