RFR: 6946: There should be an option to build the agent in the build script [v2]

Alex Macdonald aptmac at openjdk.java.net
Tue Dec 15 15:57:58 UTC 2020


On Mon, 14 Dec 2020 22:12:11 GMT, Miroslav Wengner <mwengner at openjdk.org> wrote:

>> https://bugs.openjdk.java.net/browse/JMC-6946
>> added: 
>> - build.sh --packageAgent
>> - build.sh --runAgentExample
>
> Miroslav Wengner has updated the pull request incrementally with one additional commit since the last revision:
> 
>   6946: typo correction

build.sh line 278:

> 276: }
> 277: 
> 278: function checkJava() {

This is a nice touch. It's probably not within the scope of the original issue here, but it would be nice to eventually have a check to make sure it's using JDK 11 for building jmc, otherwise currently the build script fails without displaying any helpful information.

build.sh line 24:

> 22: }
> 23: 
> 24: function installCore() {

Similar to my other comment this would be outside the scope of this issue, but it would be nice to have `installCore` as a separate argument for the build script

-------------

PR: https://git.openjdk.java.net/jmc/pull/183


More information about the jmc-dev mailing list