RFR: 6946: There should be an option to build the agent in the build script [v2]
Miroslav Wengner
mwengner at openjdk.java.net
Wed Dec 16 15:29:56 UTC 2020
On Tue, 15 Dec 2020 15:53:45 GMT, Alex Macdonald <aptmac at openjdk.org> wrote:
>> Miroslav Wengner has updated the pull request incrementally with one additional commit since the last revision:
>>
>> 6946: typo correction
>
> build.sh line 278:
>
>> 276: }
>> 277:
>> 278: function checkJava() {
>
> This is a nice touch. It's probably not within the scope of the original issue here, but it would be nice to eventually have a check to make sure it's using JDK 11 for building jmc, otherwise currently the build script fails without displaying any helpful information.
I feel similar, that it can be outside of the scope, I was already thinking about it. I think that the current the script is meant to be executed from the similar command-line and with not mutable JDK_HOME
-------------
PR: https://git.openjdk.java.net/jmc/pull/183
More information about the jmc-dev
mailing list