RFR: 7062: Update to the Eclipse 2020-12 platform

[Alex Macdonald]

On Thu, 17 Dec 2020 11:47:54 GMT, Marcus Hirt <hirt at openjdk.org> wrote:

>> Still get the same problem:
>> 
>> [ERROR] Failed to resolve target definition <snip>\platform-definition-2020-12.target: Failed to load p2 metadata repository from location https://download.eclipse.org/releases/2020-12/: Unable to read repository at https://download.eclipse.org/releases/2020-12/content.xml. ClientProtocolException: Circular redirect to 'https://download.eclipse.org/errors/404.php/' -> [Help 1]
>> 
>>  
>> 
>> Från: Jonah Graham <notifications at github.com> 
>> Skickat: den 17 december 2020 02:13
>> Till: openjdk/jmc <jmc at noreply.github.com>
>> Kopia: Marcus Hirt <marcus at hirt.se>; Author <author at noreply.github.com>
>> Ämne: Re: [openjdk/jmc] 7062: Update to the Eclipse 2020-12 platform (#185)
>> 
>>  
>> 
>> @jonahgraham commented on this pull request.
>> 
>>   _____  
>> 
>> In releng/platform-definitions/platform-definition-2020-12/platform-definition-2020-12.target <https://github.com/openjdk/jmc/pull/185#discussion_r544737739> :
>> 
>>> +            <unit id="com.sun.activation.jakarta.activation" version="1.2.1"/>
>> +            <unit id="org.owasp.encoder" version="1.2.2"/>
>> +            <unit id="org.lz4.lz4-java" version="1.7.1"/>
>> +            <unit id="org.twitter4j.core" version="4.0.7"/>
>> +            <unit id="org.hdrhistogram.HdrHistogram" version="2.1.12"/>
>> +            <unit id="org.adoptopenjdk.jemmy-awt-input" version="2.0.0"/>
>> +            <unit id="org.adoptopenjdk.jemmy-browser" version="2.0.0"/>
>> +            <unit id="org.adoptopenjdk.jemmy-core" version="2.0.0"/>
>> +            <unit id="org.adoptopenjdk.jemmy-swt" version="2.0.0"/>
>> +            <repository location="http://localhost:8080/site"/>
>> +        </location>
>> +        <location includeAllPlatforms="false" includeConfigurePhase="true" includeMode="planner" includeSource="true" type="InstallableUnit">
>> +            <unit id="org.eclipse.equinox.executable.feature.group" version="3.8.1000.v20200915-1508"/>
>> +            <unit id="org.eclipse.pde.feature.group" version="3.14.600.v20201202-1800"/>
>> +            <unit id="org.eclipse.platform.sdk" version="4.18.0.I20201202-1800"/>
>> +            <repository location="http://download.eclipse.org/releases/2020-12/"/>
>> 
>> Try using https:// to workaround the http -> https redirect issue at download.eclipse.org.
>> 
>> —
>> You are receiving this because you authored the thread.
>> Reply to this email directly, view it on GitHub <https://github.com/openjdk/jmc/pull/185#pullrequestreview-554208854> , or unsubscribe <https://github.com/notifications/unsubscribe-auth/AEA7OXLM4IWD73IQNE7QYNLSVFLLNANCNFSM4U6XVZJQ> .  <https://github.com/notifications/beacon/AEA7OXM2M4I743JNVXYS3H3SVFLLNA5CNFSM4U6XVZJ2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOEEEI4VQ.gif>
>
> Seems the problem has now been fixed on the Eclipse site. Re-running tests.

>From a testing perspective, I opened https://bugs.openjdk.java.net/browse/JMC-7068 today, where `JfrRecordingTest` hangs on Fedora after the 2020-09 update, and it continues with this 2020-12 patch.

On the first run of uitests I only ran `JfrRecordingTest` to see if it'd hang, and it did.

The second time I ran the uitests I had a test failure in [console.ui.FreezeTableTest](https://github.com/openjdk/jmc/blob/62ed0e874081870d262e41fa375b16e888329b75/application/uitests/org.openjdk.jmc.console.uitest/src/test/java/org/openjdk/jmc/console/uitest/FreezeTableTest.java#L82):
Errors: 
  FreezeTableTest.freeze:82 » IndexOutOfBounds Index 0 out of bounds for length ...

On the third run, it SIGSEGV'd at `org.openjdk.jmc.flightrecorder.uitest.ControlRecordingsTest`.

On the fourth run I ran only the tests under `flightrecorder.uitest` (without `JfrRecordingTest`), and made it through okay. 

>From a review perspective, I'm not sure how to review this one. Dependency freeze (if I'm recalling correctly) was supposed to be on pace with rampdown 1 on November 23rd, so I might have to defer to @jiekang for more insight this one, but the eclipse fedora rpm repo was recently updated to 2020-09 (4.17.0).. so I'm not sure if an extra update 2020-12 will impact a hopeful jmc release timeline on our side.

-------------

PR: https://git.openjdk.java.net/jmc/pull/185