RFR: 6677: search to highlight cells in the flame view

[Miroslav Wengner]

On Tue, 4 Feb 2020 13:32:07 GMT, Alex Macdonald <aptmac at openjdk.org> wrote:

>> @aptmac  I like your comments! 
>> add1.  agree,  I know about the issue with the window. I've been searching about how to fix it properly and it looks they have opened a bug ticket in flameview. They don't properly propagate resize to the base svg. Maybe we should wait until they have it fixed, what do you think?
>> ps: when you click on a new  thread to display (example ), all is properly resized according to the window size. (my observed behaviour)
>> 
>> add2. I've been thinking about it ! So I'll add it too let's see how performance.
> 
>> @aptmac I like your comments!
>> add1. agree, I know about the issue with the window. I've been searching about how to fix it properly and it looks they have opened a bug ticket in flameview. They don't properly propagate resize to the base svg. Maybe we should wait until they have it fixed, what do you think?
> 
> I'm the one who opened that issue on the `d3-flame-graph` repo, and I've posted on one of their issues last week so I'm not sure how long it takes to get a reply (or a fix). I think if going the route of waiting for an upstream fix then we should also update to the latest version .. we're using one 1.5 years out of date at the moment. However, this would also complicate the PR for getting this to work in Windows until Chromium support is added to SWT.
> 
> In my opinion this is something that stylesheets can address and doesn't require us to rely on external parties.
> 
>> ps: when you click on a new thread to display (example ), all is properly resized according to the window size. (my observed behaviour)
> 
> Interesting, I'm only seeing a proper resize when the chart is redrawn.
> 
> ![6677-resize-on-redraw](https://user-images.githubusercontent.com/10425301/73748384-509d3c80-4727-11ea-9141-8253a8f2cb57.gif)

![image](https://user-images.githubusercontent.com/1956942/73792107-f3939c00-47a3-11ea-8e72-4b687a163e58.png)

@aptmac I've fixed the resizing now it works on my Mac perfectly. 
I've also implement your recommendation according to the search (add.2.). It works pretty well and I think ti may sense.

![image](https://user-images.githubusercontent.com/1956942/73792373-6e5cb700-47a4-11ea-82ce-97208a093978.png)

conclusion: 
1. resize works  (on mac as I've no windows easy to access ;)
2. search considers  node and package name. It searches for the strings that contains desired sequence.
3. I've changed the highlighting color to Magenta 

what do you think now ? @thegreystone and @aptmac

-------------

PR: https://git.openjdk.java.net/jmc/pull/45