RFR: 6677: search to highlight cells in the flame view

[Miroslav Wengner]

On Wed, 5 Feb 2020 20:46:36 GMT, Alex Macdonald <aptmac at openjdk.org> wrote:

>> ticket: https://bugs.openjdk.java.net/browse/JMC-6677
> 
>> /contributor add Alex Macdonald [Alex.Mcdonald at redhat.com](mailto:Alex.Mcdonald at redhat.com)
> 
> Not sure if I'm supposed to be contributor on this PR, but my e-mail is `almacdon at redhat.com` regardless.
> 
>> conclusion:
>> 
>>     1. resize works  (on mac as I've no windows easy to access ;)
> 
> The svg stylesheet change works on Linux, and should also work on Windows.
> 
>>     2. search considers  node and package name. It searches for the strings that contains desired sequence.
> 
> The search feels more intuitive now, thanks. Is it possible to have the search fire automatically (instead of hitting enter) when a certain amount of characters are entered, maybe 3+? I think there's a table of two in JMC which operate the same way.
> 
> There appears to be an edge case somewhere when searching for the string, but it's in the JavaScript so it's difficult to debug. But I'll type out my steps that what's happening.. maybe it has something to do with escaping characters:
> - I have two entries of `ArrayList.add(Object [..])`.
> - If I search for "add(", then no node is highlighted
> - if I search for "add", then it highlights both those nodes
> - Now that the nodes are highlighted, I can type anything in the search bar and it will not update the chart i.e., the two nodes remain highlighted.
> - I would expect that inputting a string that cannot be found would highlight the nodes
> 
> Additionally, I found some formatting errors in the commits here .. but there's also quite a bit that made it through previously and it'd be nice to clean that up IMO. Do we have any JavaScript formatting guidelines that we're following?

@aptmac does it behave differently by you ? 
![image](https://user-images.githubusercontent.com/1956942/73887464-e93cd500-486b-11ea-814c-7d3254b350bd.png)

but you may be right correct with the escaping characters, I'll think about your comments tomorrow.

-------------

PR: https://git.openjdk.java.net/jmc/pull/45