[Rev 03] RFR: 6677: Search to highlight cells in the flame view

Alex Macdonald aptmac at openjdk.java.net
Thu Feb 6 16:20:03 UTC 2020


On Thu, 6 Feb 2020 14:13:14 GMT, Miroslav Wengner <mwengner at openjdk.org> wrote:

>>> Additionally, I found some formatting errors in the commits here .. but there's also quite a bit that made it through previously and it'd be nice to clean that up IMO. Do we have any JavaScript formatting guidelines that we're following?
>> 
>> Yep. They are under configuration/ide/eclipse/formatting/formattingjs.xml.
> 
> @aptmac I've added the search execution based on the input filed characters length. It looks very nice, I think it's quite intuitive now. 
> I've also added possibility to be able to search special character based string like : 'ArrayList.add(Object [..]).'  you have mentioned. 
> ![image](https://user-images.githubusercontent.com/1956942/73944619-2dbf8380-48f3-11ea-9021-93bbc698817d.png)

If I type a single "special character" (`$`, `%`, etc), then all of the nodes get highlighted. This seems to be the case for most of them, minus a few such as `(`, `)`, `+`.
![6677-highlight-all](https://user-images.githubusercontent.com/10425301/73955325-28e9d800-48d1-11ea-8a31-e14d98d5191f.gif)

It appears to only match strings with parenthesis when the entire string matches. For example, if the string is `ArrayList.add(Object)`, then it correctly matches `.add`, and `.add(Object)`, but will not highlight for `add(` or `add(O` etc.
![6677-match-whole](https://user-images.githubusercontent.com/10425301/73955460-68182900-48d1-11ea-8d8b-2340d56e13c2.gif)

The automatic highlighting after typing feels nice. Should it also clear if there's no text in the search box? If the user types in a string to search and then uses backspaces to clear the text, at the moment the labels will remain highlighted.

-------------

PR: https://git.openjdk.java.net/jmc/pull/45


More information about the jmc-dev mailing list