[Rev 06] RFR: 6677: Search to highlight cells in the flame view
Miroslav Wengner
mwengner at openjdk.java.net
Thu Feb 6 22:59:46 UTC 2020
On Thu, 6 Feb 2020 20:48:07 GMT, Miroslav Wengner <mwengner at openjdk.org> wrote:
>> If I type a single "special character" (`$`, `%`, etc), then all of the nodes get highlighted. This seems to be the case for most of them, minus a few such as `(`, `)`, `+`.
>> EDIT: er, maybe it's not important to care about all special characters because they might not be a use case .. but searching for strings with parenthesis would be nice I think.
>> 
>>
>> It appears to only match strings with parenthesis when the entire string matches. For example, if the string is `ArrayList.add(Object)`, then it correctly matches `.add`, and `.add(Object)`, but will not highlight for `add(` or `add(O` etc.
>> 
>>
>> The automatic highlighting after typing feels nice. Should it also clear if there's no text in the search box? If the user types in a string to search and then uses backspaces to clear the text, at the moment the labels will remain highlighted.
>
> @aptmac it's good point ! I've added the backspace check.
> according to the issue: ```...add(Object), but will not highlight for add( or add(O etc.``` . I see the issue with flamegraph lib itself. I'm trying to fix it.
@aptmac and @thegreystone I've enabled the full special characters search, it should work as expected. Everyone should be able find e.g.: `run(`
I've not noticed any performance issues, I hope it works similar also for you.
see images



-------------
PR: https://git.openjdk.java.net/jmc/pull/45
More information about the jmc-dev
mailing list