RFR: 6657: Add allocation pressure column to Memory and TLAB views

Marcus Hirt hirt at openjdk.java.net
Wed Feb 19 14:32:21 UTC 2020


On Fri, 7 Feb 2020 20:51:59 GMT, Jie Kang <jkang at openjdk.org> wrote:

>>> > Is it acceptable if I open another issue in JIRA to address this?
>>> 
>>> Certainly!
>> 
>> Created @ https://bugs.openjdk.java.net/browse/JMC-6678
> 
> @thegreystone Hey Marcus, the latest commit adds the backdrop bars, and the entire chain of commits in the PR is rebased on top of master commit 6dd19dd5ae3fc4c7e7bfc1e997725408188dbb79
> 
> I'm still trying to think of ways to clean up the code for backdrop bars: looking at the unit infrastructure to see how to extract the column value without needing to divide by 100, if possible, and just the addition of the code straight into the addPercentageColumn code is a bit crude and not so extensible. It works as far as I can tell, at the least.

@jiekang - Hi Jie! Did you want to spend some more time looking at ways to clean up the code for the backdrop bars before integrating this?

-------------

PR: https://git.openjdk.java.net/jmc/pull/21


More information about the jmc-dev mailing list