RFR: 6531: Make the flame chart view render labels on windows

Alex Macdonald aptmac at openjdk.java.net
Fri Jan 24 18:09:28 UTC 2020


On Fri, 24 Jan 2020 16:54:52 GMT, Jie Kang <jkang at openjdk.org> wrote:

>> To me it's a bit scary (as in possibly maintenance heavy) to make a fork of the d3-library, rather than investing in making the SWT browser component work with Edge or chromium. This could potentially be a stop gap measure though. @mirage22, would this complicate anything you were planning on doing with the flame view?
> 
> While the guard to only use this on Windows does mitigate impact of this patch, I also am concerned with maintenance of a fork of the d3-flame-graph. I would rather see the upstream updated, or as Marcus stated, the SWT browser updated to use an alternative (newer) browser.

> While the guard to only use this on Windows does mitigate impact of this patch, I also am concerned with maintenance of a fork of the d3-flame-graph. I would rather see the upstream updated, or as Marcus stated, the SWT browser updated to use an alternative (newer) browser.

That sounds fair, I replied to the original Windows-related issue and tagged the repo owner, will comment back when there's a response.

In other news it looks like the latest version of Edge is based on Chromium [[0]](https://support.microsoft.com/en-ca/help/4501095/download-the-new-microsoft-edge-based-on-chromium), so getting Chromium support would be nice. Progress on that is tracked at https://bugs.eclipse.org/bugs/show_bug.cgi?id=549585

[0] https://support.microsoft.com/en-ca/help/4501095/download-the-new-microsoft-edge-based-on-chromium

-------------

PR: https://git.openjdk.java.net/jmc/pull/41


More information about the jmc-dev mailing list