RFR: 6531: Make the flame chart view render labels on windows

[Miroslav Wengner]

On Fri, 24 Jan 2020 18:09:15 GMT, Alex Macdonald <aptmac at openjdk.org> wrote:

>> While the guard to only use this on Windows does mitigate impact of this patch, I also am concerned with maintenance of a fork of the d3-flame-graph. I would rather see the upstream updated, or as Marcus stated, the SWT browser updated to use an alternative (newer) browser.
> 
>> While the guard to only use this on Windows does mitigate impact of this patch, I also am concerned with maintenance of a fork of the d3-flame-graph. I would rather see the upstream updated, or as Marcus stated, the SWT browser updated to use an alternative (newer) browser.
> 
> That sounds fair, I replied to the original Windows-related issue and tagged the repo owner, will comment back when there's a response.
> 
> In other news it looks like the latest version of Edge is based on Chromium [[0]](https://support.microsoft.com/en-ca/help/4501095/download-the-new-microsoft-edge-based-on-chromium), so getting Chromium support would be nice. Progress on that is tracked at https://bugs.eclipse.org/bugs/show_bug.cgi?id=549585
> 
> [0] https://support.microsoft.com/en-ca/help/4501095/download-the-new-microsoft-edge-based-on-chromium

It doesn't feel right to me to maintain d3-flame-graph fork, as @thegreystone stated it's a bit scary.   
I'd rather to stay with ECMA 6 due to the d3 library compatibility and its future development. 

 I'd propose the way @thegreystone has stated -> SWT update to use an alternative (newer) browser.

we are planning to do the search/highlighting of nodes inside the flameview.  This feature uses d3-lib functionality. I don't know whether this patch will not force us to maintain also the fork of d3 itself.

-------------

PR: https://git.openjdk.java.net/jmc/pull/41