Sv: [backport][7.1.1] RFR: JMC-6554 & JMC-6692

[Marcus Hirt]

Excellent! Thanks Alex!

Kind regards,
Marcus

-----Ursprungligt meddelande-----
Från: jmc-dev <jmc-dev-bounces at openjdk.java.net> För Alex Macdonald
Skickat: den 4 juni 2020 22:03
Till: Marcus Hirt <marcus.hirt at datadoghq.com>
Kopia: jmc-dev at openjdk.java.net
Ämne: Re: [backport][7.1.1] RFR: JMC-6554 & JMC-6692

Hi Marcus,

On Thu, Jun 4, 2020 at 6:59 AM Marcus Hirt <marcus.hirt at datadoghq.com>
wrote:

> Hi Alex,
>
> LGTM! I pinged you about the minimum amount of testing I think should 
> be done, but feel free to submit after the appropriate testing has been done!
>

Thanks for the reply! I've gone and tested the patches, and attached some screenshots to the JIRA ticket for the backport of 6692:
https://bugs.openjdk.java.net/browse/JMC-6822

I gave the functionality a quick run-through on both Fedora 31 and Windows 10, using: Oracle JDK 8, OpenJDK 8, OpenJDK8 with JFR, and OpenJDK 11. Both Windows and Fedora displayed the same behaviour when trying to start a flight recording, or trying to view current recordings by expanding the Flight Recorder tree item in the JVM Browser.

1. With Oracle JDK 8, expanding the Flight Recorder tree item results in the dialog explaining that JFR isn't enabled, and trying to start a recording results in the dialog prompting the user to enable commercial features.
Fedora warning dialog:
https://bugs.openjdk.java.net/secure/attachment/88568/linux-oracle8-1-warning.png
Fedora enable commercial features:
https://bugs.openjdk.java.net/secure/attachment/88569/linux-oracle8-2-enable.png
Windows warning dialog:
https://bugs.openjdk.java.net/secure/attachment/88575/windows-oracle8-1-warning.png
Windows enable commercial features:
https://bugs.openjdk.java.net/secure/attachment/88576/windows-oracle8-2-enable.png

2. With OpenJDK 8, the error message was updated to mention that Flight Recorder would work with an OpenJDK 8 with JFR enabled.
Fedora warning dialog:
https://bugs.openjdk.java.net/secure/attachment/88563/linux-ojdk8-1-warning.png
Fedora cannot record:
https://bugs.openjdk.java.net/secure/attachment/88564/linux-ojdk8-2-enable.png
Windows warning dialog:
https://bugs.openjdk.java.net/secure/attachment/88570/windows-ojdk8-1-warning.png
Windows cannot record:
https://bugs.openjdk.java.net/secure/attachment/88571/windows-ojdk8-2-enable.png

3. With OpenJDK 8 with JFR enabled, the wizard opens without warning and there wasn't any issue dumping and opening the recording.
Fedora JFR wizard:
https://bugs.openjdk.java.net/secure/attachment/88565/linux-ojdk8jfr-1-wizard.png
Fedora recording dumped & opened:
https://bugs.openjdk.java.net/secure/attachment/88566/linux-ojdk8jfr-2-dumped.png
Windows JFR wizard:
https://bugs.openjdk.java.net/secure/attachment/88572/windows-ojdk8jfr-1-wizard.png
Windows recording dumped & opened:
https://bugs.openjdk.java.net/secure/attachment/88573/windows-ojdk8jfr-2-dumped.png

4. With OpenJDK 11, the wizard opens without warning and there wasn't any issue dumping and opening the recording.
Fedora:
https://bugs.openjdk.java.net/secure/attachment/88567/linux-ojdk11.png
Windows:
https://bugs.openjdk.java.net/secure/attachment/88574/windows-ojdk11.png

If there's anything else you'd like me to check while I have this setup, let me know.

Cheers,

Alex


> Kind regards,
> Marcus
>
> On Wed, Jun 3, 2020 at 9:57 PM Alex Macdonald <almacdon at redhat.com> wrote:
>
>> Hi everyone,
>>
>> Please consider these two webrevs [0][1] for backporting the 
>> following into JMC 7:
>>
>> JMC-6554: Support JFR in OpenJDK 8 [2] and
>> JMC-6692: JMC is asking to unlock Commercial Features on JFR enabled
>> OpenJDK8 [3].
>>
>> These patches together allow for improved handling of Flight 
>> Recordings with OpenJDK 8. As far as the patches are concerned, 
>> JMC-6692 relies on the changes in 6554, so the patches need to be 
>> applied in the order of 6554 -> 6692.
>>
>> For reference, the original commits can be found at the following links:
>> JMC-6554:
>>
>> https://github.com/openjdk/jmc/commit/4b315fe62adb44c5524b55cac2e286f
>> a22324573
>> JMC-6692
>> <https://github.com/openjdk/jmc/commit/4b315fe62adb44c5524b55cac2e286
>> fa22324573JMC-6692>
>> :
>>
>> https://github.com/openjdk/jmc/commit/efc952149024cfb3d92863bd9103959
>> 46d0beffe
>>
>> Cheers,
>>
>> Alex
>>
>> [0] http://cr.openjdk.java.net/~aptmac/JMC-6554/webrev.01/
>> [1] http://cr.openjdk.java.net/~aptmac/JMC-6692/webrev.01/
>> [2] https://bugs.openjdk.java.net/browse/JMC-6554
>> [3] https://bugs.openjdk.java.net/browse/JMC-6692
>>
>