RFR: 6531: Make the flame chart view render labels on windows

Marcus Hirt hirt at openjdk.java.net
Fri Jun 5 12:31:22 UTC 2020


On Wed, 27 May 2020 16:40:43 GMT, Thomas May <github.com+4906592+cogman at openjdk.org> wrote:

>>> As soon as the Eclipse changes are in, in any form and shape, we should switch.
>> 
>> Agreed, it would be very limiting to continue on this way.
>> 
>> This PR required some rebasing after the latest flamegraph commits to include colour highlighting. I had to include an
>> additional commit here that allows for the colouring to work with IE, because some syntax and functions are too
>> advanced for ES2015.  About the `flameviewColoring.js`, I made the changes in the file to make it compatible with IE,
>> but would it be worthwhile to go the route of making a `flameviewColoring-ie.js` so that if/when Chromium functionality
>> is introduced instead of refactoring the colouring script we could just drop the `-ie` version? Let me know your
>> thoughts on this one.  Here's an example screenshot of it working in Windows with text highlighting:
>> ![windows-highlighting](https://user-images.githubusercontent.com/10425301/75188682-92177b00-571a-11ea-9a3f-e8bd7b91d3b9.png)
>
> Dumb question, but would a shorter path be to run babel against d3 (Or have that as part of the build?)
> 
> That would eliminate the need to maintain your own version and make updating a lot easier.

Hi Alex!

I think https://bugs.eclipse.org/bugs/show_bug.cgi?id=549585 is getting closer to release. Any chance you could see if
that works as a drop-in replacement?

-------------

PR: https://git.openjdk.java.net/jmc/pull/41


More information about the jmc-dev mailing list