RFR: 6810: Create treemap viewer for JOverflow [v9]
Marcus Hirt
hirt at openjdk.java.net
Thu Jun 25 18:32:28 UTC 2020
On Thu, 25 Jun 2020 18:27:02 GMT, Marcus Hirt <hirt at openjdk.org> wrote:
>> I saw this practice when studying the Eclipse SWT source. There is no important reason for explicitly calling out these
>> methods/classes being`/* package-private */`. I thought it was more like a good-to-have sort of things.
>> I'll refrain from doing this in the future. Please let me know if you prefer removing these comments throughout this
>> patch.
>
> Personally I'd prefer to have them removed.
Or added as a proper comment with the reasoning for them being package private...
/*
* This method is package private since ClassX needs to access the internal state without having to do a defensive copy
every time, but we don't want to have it exposed in the public API since blahblahblah.
*/
-------------
PR: https://git.openjdk.java.net/jmc/pull/77
More information about the jmc-dev
mailing list