RFR: 6810: Create treemap viewer for JOverflow [v9]
    Kangcheng Xu 
    kxu at openjdk.java.net
       
    Thu Jun 25 19:06:01 UTC 2020
    
    
  
On Thu, 25 Jun 2020 18:30:20 GMT, Marcus Hirt <hirt at openjdk.org> wrote:
>> Personally I'd prefer to have them removed.
>
> Or added as a proper comment with the reasoning for them being package private...
> 
> /*
>  * This method is package private since ClassX needs to access the internal state without having to do a defensive copy
>    every time, but we don't want to have it exposed in the public API since blahblahblah.
> */
> Personally I'd prefer to have them removed.
All `/* package-private */` comments are removed in commit aaaab0b.
-------------
PR: https://git.openjdk.java.net/jmc/pull/77
    
    
More information about the jmc-dev
mailing list