RFR: 6542: Improve calls to render in the flame view [v6]

Miroslav Wengner mwengner at openjdk.java.net
Tue Oct 20 19:41:24 UTC 2020


On Tue, 20 Oct 2020 19:34:20 GMT, Marcus Hirt <hirt at openjdk.org> wrote:

>> Miroslav Wengner has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev
>> excludes the unrelated changes brought in by the merge/rebase. The pull request contains ten additional commits since
>> the last revision:
>>  - Merge branch 'master' of https://github.com/openjdk/jmc into feature/6542_Improve_calls_to_render_in_the_flame_view
>>  - 6542:  spotless needs
>>  - 6542: cleanup
>>  - 6542: typo correction
>>  - 6542: correction to aboring callable
>>  - 6542: minor changes
>>  - 6542: comments model calculation cancelation
>>  - 6542: cleanup
>>  - 6542: correction flameview display,  model calculation separation
>
> application/org.openjdk.jmc.flightrecorder.flameview/src/main/java/org/openjdk/jmc/flightrecorder/flameview/views/FlameGraphView.java
> line 285:
>> 283: 	private static class ModelRebuildCallable implements Callable<Void> {
>> 284:
>> 285: 		private volatile boolean invalid;
> 
> Should probably be isInvalid.

done!

> application/org.openjdk.jmc.flightrecorder.flameview/src/main/java/org/openjdk/jmc/flightrecorder/flameview/views/FlameGraphView.java
> line 290:
>> 288:
>> 289: 		private ModelRebuildCallable(FlameGraphView view, IItemCollection items) {
>> 290: 			this.invalid = false;
> 
> This line should be removed.

done

-------------

PR: https://git.openjdk.java.net/jmc/pull/133


More information about the jmc-dev mailing list