RFR: 6542: Improve calls to render in the flame view [v6]
Miroslav Wengner
mwengner at openjdk.java.net
Tue Oct 20 19:44:21 UTC 2020
On Tue, 20 Oct 2020 19:35:52 GMT, Marcus Hirt <hirt at openjdk.org> wrote:
>> Miroslav Wengner has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev
>> excludes the unrelated changes brought in by the merge/rebase. The pull request contains ten additional commits since
>> the last revision:
>> - Merge branch 'master' of https://github.com/openjdk/jmc into feature/6542_Improve_calls_to_render_in_the_flame_view
>> - 6542: spotless needs
>> - 6542: cleanup
>> - 6542: typo correction
>> - 6542: correction to aboring callable
>> - 6542: minor changes
>> - 6542: comments model calculation cancelation
>> - 6542: cleanup
>> - 6542: correction flameview display, model calculation separation
>
> application/org.openjdk.jmc.flightrecorder.flameview/src/main/java/org/openjdk/jmc/flightrecorder/flameview/views/FlameGraphView.java
> line 170:
>> 168: private IItemCollection currentItems;
>> 169: private ModelState modelState = ModelState.NONE;
>> 170: private ModelRebuildCallable modelRebuildCalllable;
>
> One l too many.
done
> application/org.openjdk.jmc.flightrecorder.flameview/src/main/java/org/openjdk/jmc/flightrecorder/flameview/views/FlameGraphView.java
> line 387:
>> 385: // Release old model calculation before building a new
>> 386: if (modelCalculationFuture != null) {
>> 387: modelRebuildCalllable.setInvalid();
>
> One l too many.
done
-------------
PR: https://git.openjdk.java.net/jmc/pull/133
More information about the jmc-dev
mailing list