RFR: 6669: FlameGraphView tree calculation should (probably) be interruptable

Wed Oct 21 13:27:13 UTC 2020

On Wed, 21 Oct 2020 11:52:24 GMT, Marcus Hirt <hirt at openjdk.org> wrote:

>> fix to bug: https://bugs.openjdk.java.net/browse/JMC-6669
>
> application/org.openjdk.jmc.flightrecorder.flameview/src/main/java/org/openjdk/jmc/flightrecorder/flameview/views/FlameGraphView.java line 306:
> 
>> 304: 			}
>> 305: 			TraceNode traceNode = TraceTreeUtils.createTree(root, model);
>> 306: 			String jsonModel = view.toJSonModel(traceNode, isInvalid).toString();
> 
> Java is pass by value. You'll need to pass a reference to this (the ModelRebuildCallable) and query that for isInvalid(), otherwise you'll only have the value at the time of the invocation passed around.

Correct! all object references are passed by value... should wait till morning to not overlook it.

-------------

PR: https://git.openjdk.java.net/jmc/pull/135