RFR: 6669: FlameGraphView tree calculation should (probably) be interruptable [v2]

[Miroslav Wengner]

On Wed, 21 Oct 2020 13:24:43 GMT, Miroslav Wengner <mwengner at openjdk.org> wrote:

>> application/org.openjdk.jmc.flightrecorder.flameview/src/main/java/org/openjdk/jmc/flightrecorder/flameview/views/FlameGraphView.java line 306:
>> 
>>> 304: 			}
>>> 305: 			TraceNode traceNode = TraceTreeUtils.createTree(root, model);
>>> 306: 			String jsonModel = view.toJSonModel(traceNode, isInvalid).toString();
>> 
>> Java is pass by value. You'll need to pass a reference to this (the ModelRebuildCallable) and query that for isInvalid(), otherwise you'll only have the value at the time of the invocation passed around.
>
> Correct! all object references are passed by value... should wait till morning to not overlook it.

corrected!

-------------

PR: https://git.openjdk.java.net/jmc/pull/135