RFR: 6946: There should be an option to build the agent in the build script [v8]

[Miroslav Wengner]

On Wed, 6 Jan 2021 08:18:22 GMT, Patrick Reinhart <reinhapa at openjdk.org> wrote:

>> build.sh line 88:
>> 
>>> 86:         printf " \t%s\t%s\n" "--clean" "to run maven clean"
>>> 87:         printf " \t%s\t%s\n" "--run" "to run JMC once it was packaged"
>>> 88:         printf " \t%s\t%s\n" "--runAgentExample" "to run Agent Example once it was packaged"
>> 
>> Any chance you could also add --runAgentConverterExample? :)
>> 
>> Basically:
>> --add-opens java.base/jdk.internal.misc=ALL-UNNAMED -XX:+FlightRecorder -javaagent:${resource_loc:/org.openjdk.jmc.agent/target/org.openjdk.jmc.agent-1.0.0-SNAPSHOT.jar}=${resource_loc:/org.openjdk.jmc.agent/src/test/resources/org/openjdk/jmc/agent/converters/test/jfrprobes_template.xml}
>
> Although I'm not an reviewer �� it seems that the `build.cmd` is missing the `--runAgentExample` additon mentioned by @thegreystone. Anything else looks ok.

the reason of missing --runAgentExample option is the proper java version detection. I've not found quite nice way hot to do it. Maybe you have some proposal @reinhapa  ?

-------------

PR: https://git.openjdk.java.net/jmc/pull/183