RFR: 7167: Agent Plugin [v6]

[Jie Kang]

On Wed, 28 Apr 2021 17:57:17 GMT, Joshua Matsuoka <jmatsuoka at openjdk.org> wrote:

>> This PR adds the Agent Plugin to JMC. This is a plugin for controlling the jmc agent and provides a way to attach it and add probes to any JVMs in the JVM browser, as well as providing a preset manager for creating/modifying probe presets.
>> 
>> There is still a small amount of cleanup to be done so I'll mark it as a draft for now but it would be great to get a review :)
>
> Joshua Matsuoka has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Fix rcp feature to use new agent plugin name

application/org.openjdk.jmc.console.agent/src/main/java/org/openjdk/jmc/console/agent/manager/model/CapturedValue.java line 49:

> 47: 	private static final String DEFAULT_STRING_FIELD = ""; // $NON-NLS-1$
> 48: 	private static final Object DEFAULT_OBJECT_TYPE = null;
> 49: 	private static final String CONVERTER_REGEX = "([a-zA-Z_$][a-zA-Z0-9_$]*\\.)*([a-zA-Z_$][a-zA-Z0-9_$]*)"; // $NON-NLS-1$

If possible I'd appreciate a comment on this Regex or class to share intention.

application/org.openjdk.jmc.console.agent/src/main/java/org/openjdk/jmc/console/agent/manager/model/Field.java line 45:

> 43: 	private static final String DEFAULT_FIELD_NAME = "New Field"; // $NON-NLS-1$
> 44: 	private static final String DEFAULT_FIELD_EXPRESSION = "myField"; // $NON-NLS-1$
> 45: 	private static final String EXPRESSION_REGEX = "([a-zA-Z_$][a-zA-Z0-9_$]*\\.)*([a-zA-Z_$][a-zA-Z0-9_$]*)(\\.[a-zA-Z_$][a-zA-Z_$]*)*"; // $NON-NLS-1$

Similarly here. I'm guessing it's to match valid field names?

-------------

PR: https://git.openjdk.java.net/jmc/pull/226