RFR: 7167: Agent Plugin [v6]

Jie Kang jkang at openjdk.java.net
Tue Jun 1 20:29:12 UTC 2021


On Thu, 27 May 2021 09:02:18 GMT, Brice Dutheil <github.com+803621+bric3 at openjdk.org> wrote:

>> Joshua Matsuoka has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Fix rcp feature to use new agent plugin name
>
> application/org.openjdk.jmc.console.agent/src/main/java/org/openjdk/jmc/console/agent/manager/model/PresetRepositoryFactory.java line 85:
> 
>> 83: 		for (File file : files) {
>> 84: 			if (file.length() == 0) {
>> 85: 				// FIXME: delete or just ignore empty files? 
> 
> Maybe ignore empty files but report them in a logger ?

Agreed with ignoring and logging

-------------

PR: https://git.openjdk.java.net/jmc/pull/226


More information about the jmc-dev mailing list