RFR: 7167: Agent Plugin [v6]

[Jie Kang]

On Wed, 28 Apr 2021 17:57:17 GMT, Joshua Matsuoka <jmatsuoka at openjdk.org> wrote:

>> This PR adds the Agent Plugin to JMC. This is a plugin for controlling the jmc agent and provides a way to attach it and add probes to any JVMs in the JVM browser, as well as providing a preset manager for creating/modifying probe presets.
>> 
>> There is still a small amount of cleanup to be done so I'll mark it as a draft for now but it would be great to get a review :)
>
> Joshua Matsuoka has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Fix rcp feature to use new agent plugin name

application/org.openjdk.jmc.console.agent/src/main/java/org/openjdk/jmc/console/agent/manager/wizards/CapturedValueEditingPage.java line 222:

> 220: 		IMethodParameter parameter = (IMethodParameter) capturedValue;
> 221: 
> 222: 		// TODO: do this is in model instead

I don't think these todos are too good for non-authors to really know what should needs to be done instead. I'd rephrase them or remove them

application/org.openjdk.jmc.feature.console.agent/feature.xml line 14:

> 12:       <import feature="org.openjdk.jmc.feature.core" version="8.0.0.qualifier"/>
> 13:       <import feature="org.openjdk.jmc.feature.console" version="8.0.0.qualifier"/>
> 14:       <import plugin="org.openjdk.jmc.console.agent"/>

Does it make sense to have a version here for this requires?

application/org.openjdk.jmc.feature.console/feature.xml line 59:

> 57:          install-size="0"
> 58:          version="0.0.0"
> 59:          unpack="false"/> 

I think this change can be pruned

-------------

PR: https://git.openjdk.java.net/jmc/pull/226