RFR: 7167: Agent Plugin [v6]

Joshua Matsuoka jmatsuoka at openjdk.java.net
Tue Jun 15 16:52:20 UTC 2021


On Tue, 1 Jun 2021 20:26:14 GMT, Jie Kang <jkang at openjdk.org> wrote:

>> application/org.openjdk.jmc.console.agent/src/main/java/org/openjdk/jmc/console/agent/manager/model/PresetRepositoryFactory.java line 85:
>> 
>>> 83: 		for (File file : files) {
>>> 84: 			if (file.length() == 0) {
>>> 85: 				// FIXME: delete or just ignore empty files? 
>> 
>> Maybe ignore empty files but report them in a logger ?
>
> Agreed with ignoring and logging

Agreed, fixed now. It will log the exception

-------------

PR: https://git.openjdk.java.net/jmc/pull/226


More information about the jmc-dev mailing list