RFR: 7262: Add rule for when the JVM version is < OpenJDK 8u302 [v3]
Oskar Jung
github.com+1101441+ojung at openjdk.java.net
Wed Jun 2 14:44:49 UTC 2021
On Wed, 2 Jun 2021 13:25:11 GMT, Brice Dutheil <github.com+803621+bric3 at openjdk.org> wrote:
>> core/org.openjdk.jmc.common/src/main/java/org/openjdk/jmc/common/version/JavaVersion.java line 168:
>>
>>> 166: return thisNumber > otherNumber;
>>> 167: }
>>> 168: }
>>
>> It would be nice to avoid code duplication with the above method `isGreaterOrEqualThan`
>
> Also I think the copyright year need to be bumped to 2021 for this file
I addressed these in the fixup commits. Let me know if you agree with the changes from the fixups and then I will squash them and force push again.
-------------
PR: https://git.openjdk.java.net/jmc/pull/256
More information about the jmc-dev
mailing list