RFR: 7262: Add rule for when the JVM version is < OpenJDK 8u302 [v2]
Oskar Jung
github.com+1101441+ojung at openjdk.java.net
Wed Jun 2 14:11:55 UTC 2021
On Wed, 2 Jun 2021 13:33:06 GMT, Brice Dutheil <github.com+803621+bric3 at openjdk.org> wrote:
>> Oskar Jung has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains one new commit since the last revision:
>>
>> 7262: Add rule for when the JVM version is < OpenJDK 8u302
>>
>> Since the test flight recording was created with 8u302 EA, a method
>> `JavaVersion.isGreaterOrEqualThanDisregardEa` had to be added to compare
>> java versions disregarding early access status.
>
> Some nitpicks, but it seems good!
Hey @bric3, thanks for your comments! Unfortunately I didn't notice you already started reviewing. I force-pushed a rewritten commit. The difference is, that I now check if it is an `OpenJDK`. See https://github.com/openjdk/jmc/pull/256/files#diff-d03e56fffa9483fb8054f457e45a52a76c057012d19c9d68ec88926db8a0624fR83-R85
-------------
PR: https://git.openjdk.java.net/jmc/pull/256
More information about the jmc-dev
mailing list