RFR: 7041: Add Percentage column based on Duration in stack trace view [v2]
Alex Macdonald
aptmac at openjdk.java.net
Wed Jun 2 15:06:28 UTC 2021
On Wed, 2 Jun 2021 14:12:49 GMT, Suchita Chaturvedi <schaturvedi at openjdk.org> wrote:
>> This PR address the enhancement requested by one of our customers where they were missing the percentage column by duration in stacktrace view which was available in JMC 5.5. Currently we have percentage column which is calculating the percentage based on event count and there is no way user can configure that.
>>
>> Since this functionality might not be used by many customers I have added a toggle icon in Stacktrace View so that user can set the view according to his preference and by default the new column will be hidden.
>>
>> Default view showing toggle icon:
>> 
>>
>> Percentage By Duration Column :
>> 
>>
>> Please review the change and let me know your valuable feedback on this.
>
> Suchita Chaturvedi has updated the pull request incrementally with one additional commit since the last revision:
>
> Update Copyright year
The functionality here looks good to me.
My only nit is that the column doesn't appear to be created with set weights (maybe it's a linux thing?) and the width of the new column is very large.
For example, when trying it for the first time I was confused why the column wasn't appearing, but it is just created with a 0 size and needs to be drag expanded. Additionally, to be able to actually read the column contents the width has to be made very large to the point where it overlaps the other column, but again that's probably just a nit on the size of my monitor.

-------------
Marked as reviewed by aptmac (Committer).
PR: https://git.openjdk.java.net/jmc/pull/257
More information about the jmc-dev
mailing list