RFR: 7041: Add Percentage column based on Duration in stack trace view [v2]

Suchita Chaturvedi schaturvedi at openjdk.java.net
Wed Jun 2 15:21:38 UTC 2021


On Wed, 2 Jun 2021 15:03:33 GMT, Alex Macdonald <aptmac at openjdk.org> wrote:

> The functionality here looks good to me.
> 
> My only nit is that the column doesn't appear to be created with set weights (maybe it's a linux thing?) and the width of the new column is very large.
> 
> For example, when trying it for the first time I was confused why the column wasn't appearing, but it is just created with a 0 size and needs to be drag expanded. Additionally, to be able to actually read the column contents the width has to be made very large to the point where it overlaps the other column, but again that's probably just a nit on the size of my monitor.
> ![7041](https://user-images.githubusercontent.com/10425301/120503986-c0f6b500-c391-11eb-8035-d49cecd694d0.gif)

Thanks for the approval. It looks perfectly fine in Windows. I will create a separate bug and look into it for Linux.

-------------

PR: https://git.openjdk.java.net/jmc/pull/257


More information about the jmc-dev mailing list