RFR: 7167: Agent Plugin [v6]

[Henrik Dafgård]

On Tue, 1 Jun 2021 20:12:29 GMT, Jie Kang <jkang at openjdk.org> wrote:

>> Joshua Matsuoka has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Fix rcp feature to use new agent plugin name
>
> application/org.openjdk.jmc.console.agent/src/main/java/org/openjdk/jmc/console/agent/actions/AgentEditorOpener.java line 100:
> 
>> 98: 				return ret;
>> 99: 			} catch (ConnectionException e) {
>> 100: 				// FIXME: Show stacktrace? (Need to show our own ExceptionDialog in that case, or maybe create our own DetailsAreaProvider, see WorkbenchStatusDialogManager.setDetailsAreaProvider)
> 
> Personally not a fan of PRs that add FIXMEs; can you provide some justification for having this? What's preventing this being done sooner rather than later?

+1
Either add an issue in JIRA or fix the issue in the initial PR.

-------------

PR: https://git.openjdk.java.net/jmc/pull/226