RFR: 7167: Agent Plugin [v6]
Joshua Matsuoka
jmatsuoka at openjdk.java.net
Tue Jun 15 17:04:48 UTC 2021
On Wed, 2 Jun 2021 14:45:48 GMT, Henrik Dafgård <hdafgard at openjdk.org> wrote:
>> application/org.openjdk.jmc.console.agent/src/main/java/org/openjdk/jmc/console/agent/actions/AgentEditorOpener.java line 100:
>>
>>> 98: return ret;
>>> 99: } catch (ConnectionException e) {
>>> 100: // FIXME: Show stacktrace? (Need to show our own ExceptionDialog in that case, or maybe create our own DetailsAreaProvider, see WorkbenchStatusDialogManager.setDetailsAreaProvider)
>>
>> Personally not a fan of PRs that add FIXMEs; can you provide some justification for having this? What's preventing this being done sooner rather than later?
>
> +1
> Either add an issue in JIRA or fix the issue in the initial PR.
Fixed this to show an exception dialog, thanks
-------------
PR: https://git.openjdk.java.net/jmc/pull/226
More information about the jmc-dev
mailing list