RFR: 7167: Agent Plugin [v6]

Miroslav Wengner mwengner at openjdk.java.net
Tue Jun 15 12:11:41 UTC 2021


On Wed, 28 Apr 2021 17:57:17 GMT, Joshua Matsuoka <jmatsuoka at openjdk.org> wrote:

>> This PR adds the Agent Plugin to JMC. This is a plugin for controlling the jmc agent and provides a way to attach it and add probes to any JVMs in the JVM browser, as well as providing a preset manager for creating/modifying probe presets.
>> 
>> There is still a small amount of cleanup to be done so I'll mark it as a draft for now but it would be great to get a review :)
>
> Joshua Matsuoka has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Fix rcp feature to use new agent plugin name

I've tried to run the Agent Plugin, was kind of not success. I've cloned the branch: agent-plugin
used JDK: OpenJDK 11.0.2
1. the project org.openjdk.jmc.console.agent  is not properly imported into my workspace as Java project, sadly
![image](https://user-images.githubusercontent.com/1956942/122049043-43479600-cde2-11eb-8562-22a162431c2e.png)

2. I had to remove the ".ext." from the links to get a following result:
![image](https://user-images.githubusercontent.com/1956942/122049151-6114fb00-cde2-11eb-847f-02b9d8236a5d.png)
- it worked when I've attached the xml with the agent definition, I could record the events 
![image](https://user-images.githubusercontent.com/1956942/122049415-adf8d180-cde2-11eb-9365-aded7816429c.png)

I've a seems replacing the current agent didn't work, Is this desired behaviour ?  

3. I still didn't get Agent icon displayed properly. 

Maybe I can add my changes with removing ".ext" from the package names, what do you think ?

-------------

PR: https://git.openjdk.java.net/jmc/pull/226


More information about the jmc-dev mailing list