RFR: 7167: Agent Plugin [v6]

[Joshua Matsuoka]

On Tue, 15 Jun 2021 12:08:35 GMT, Miroslav Wengner <mwengner at openjdk.org> wrote:

>> Joshua Matsuoka has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Fix rcp feature to use new agent plugin name
>
> I've tried to run the Agent Plugin, was kind of not success. I've cloned the branch: agent-plugin
> used JDK: OpenJDK 11.0.2
> 1. the project org.openjdk.jmc.console.agent  is not properly imported into my workspace as Java project, sadly
> ![image](https://user-images.githubusercontent.com/1956942/122049043-43479600-cde2-11eb-8562-22a162431c2e.png)
> 
> 2. I had to remove the ".ext." from the links to get a following result:
> ![image](https://user-images.githubusercontent.com/1956942/122049151-6114fb00-cde2-11eb-847f-02b9d8236a5d.png)
> - it worked when I've attached the xml with the agent definition, I could record the events 
> ![image](https://user-images.githubusercontent.com/1956942/122049415-adf8d180-cde2-11eb-9365-aded7816429c.png)
> 
> I've a seems replacing the current agent didn't work, Is this desired behaviour ?  
> 
> 3. I still didn't get Agent icon displayed properly. 
> 
> Maybe I can add my changes with removing ".ext" from the package names, what do you think ?

@mirage22 @bric3 I've updated the PR, there were a couple of spots that got missed by eclipse when I was renaming everything and removing the exts. For whatever reason my local build worked but making a fresh build didn't, so I missed that, apologies. It's been fixed now and should work as expected

> I've a seems replacing the current agent didn't work, Is this desired behaviour ?

This sounds like a possible agent bug, I'll take a look and get back to you on that

-------------

PR: https://git.openjdk.java.net/jmc/pull/226