RFR: 6967: Add Percentage Column w.r.t 'Profiling Samples' in Thread table

[Alex Macdonald]

On Wed, 9 Jun 2021 09:45:23 GMT, Guru Hb <ghb at openjdk.org> wrote:

> Adding "Percentage" column in Thread table (JavaApplication View). which is helpful in knowing the ratio w.r.t "Profiling Samples"
> JMC 5.x had the Percentage Column in "Hot threads" tab.

The column looks good to me, I did have a question about whether or not the strings should be externalized or not.

application/org.openjdk.jmc.flightrecorder.ui/src/main/java/org/openjdk/jmc/flightrecorder/ui/pages/JavaApplicationPage.java line 210:

> 208: 				Messages.JavaApplicationPage_COLUMN_THREAD_DURATION_DESC);
> 209: 		HISTOGRAM.addPercentageColumn(PROFILING_PERCENTAGE_COL, JdkAggregators.EXECUTION_SAMPLE_COUNT, "Percentage",
> 210: 				"Percentage over total Profiling samples");

This looks to be the only instance in the class that uses non-externalized strings, should these be put into Messages.java?

-------------

PR: https://git.openjdk.java.net/jmc/pull/260