RFR: 6967: Add Percentage Column w.r.t 'Profiling Samples' in Thread table [v2]

Guru Hb ghb at openjdk.java.net
Mon Jun 21 08:28:57 UTC 2021


On Fri, 18 Jun 2021 18:22:33 GMT, Alex Macdonald <aptmac at openjdk.org> wrote:

>> Guru Hb has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   externalize Table column name and its description
>
> application/org.openjdk.jmc.flightrecorder.ui/src/main/java/org/openjdk/jmc/flightrecorder/ui/pages/JavaApplicationPage.java line 210:
> 
>> 208: 				Messages.JavaApplicationPage_COLUMN_THREAD_DURATION_DESC);
>> 209: 		HISTOGRAM.addPercentageColumn(PROFILING_PERCENTAGE_COL, JdkAggregators.EXECUTION_SAMPLE_COUNT, "Percentage",
>> 210: 				"Percentage over total Profiling samples");
> 
> This looks to be the only instance in the class that uses non-externalized strings, should these be put into Messages.java?

This should have been externalised, Its fixed now, Please re-check and update your comments.

-------------

PR: https://git.openjdk.java.net/jmc/pull/260


More information about the jmc-dev mailing list