RFR: 7167: Agent Plugin [v9]

[Joshua Matsuoka]

On Sun, 20 Jun 2021 08:20:42 GMT, Brice Dutheil <github.com+803621+bric3 at openjdk.org> wrote:

> The help button on the dialog with the question mark does nothing.

That help button should just be hidden, the textbox hints already tell the user exactly what's needed

>  If I only give the agent jar path eg : agent/target/org.openjdk.jmc.agent-1.0.0-SNAPSHOT.jar
>
> Then the agent editor is empty:

This is intended behaviour, there are no probes inserted, so there's nothing to display

> Then doing something silly I clicked on the save preset and SAX error when saving as the preset is empty.

We should have a more meaningful error if the preset is empty, I'll fix that

> Is there no way to stop a running agent and restart the agent, so it's possible to give a different configuration. I didn't have the time to explore the agent at this time.

Not to stop/restart a running agent, but defineEventProbes already reverts existing instrumentation and inserts new probes (i.e. it will override the current configuration).

-------------

PR: https://git.openjdk.java.net/jmc/pull/226