RFR: 7167: Agent Plugin [v9]

Joshua Matsuoka jmatsuoka at openjdk.java.net
Wed Jun 23 16:08:32 UTC 2021


On Sun, 20 Jun 2021 07:21:06 GMT, Brice Dutheil <github.com+803621+bric3 at openjdk.org> wrote:

>> Joshua Matsuoka has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Resolving an issue with generated XML for field capturing/parameter capturing
>
> application/org.openjdk.jmc.console.agent/src/main/java/org/openjdk/jmc/console/agent/raweditor/internal/XmlDocumentProvider.java line 85:
> 
>> 83: 		}
>> 84: 
>> 85: 		try (Writer writer = new OutputStreamWriter(new FileOutputStream(out), StandardCharsets.UTF_8)) {
> 
> I think this should be decorated by `BufferedWriter`. Indeed saving is a manual action, but I believe this is better.

Fixed, thanks

-------------

PR: https://git.openjdk.java.net/jmc/pull/226


More information about the jmc-dev mailing list