RFR: 6204: Flight recorder launcher tab bugs out [v2]

[Miroslav Wengner]

On Mon, 21 Jun 2021 19:50:26 GMT, Miroslav Wengner <mwengner at openjdk.org> wrote:

>> application/org.openjdk.jmc.ide.launch/src/main/java/org/openjdk/jmc/ide/launch/JfrLaunchPage.java line 54:
>> 
>>> 52: 	private Button enabledCheckbox;
>>> 53: 	private Button autoOpenCheckbox;
>>> 54: 	private Button lessThenOracleJDK11Checkbox;
>> 
>> lessThen -> lessThan
>
> Thank you for spotting typos, I've changed them but seems I've not pushed it.

The problem was that the Eclipse plugin has started with specific JVM (hardcoded), I've not find the way how to detect/change the JVM that plugin uses to execute app inside the Eclipse plugin.. It was throwing an exception due to the enable commercial flag. The clearest way I've found was the ArgsBuilder,  then I had to add checkbox to propagate the option add/not add commercial features, resp. "-XX:+UnlockCommercialFeature". I've removed the TODOs

-------------

PR: https://git.openjdk.java.net/jmc/pull/265