RFR: 6204: Flight recorder launcher tab bugs out [v2]

[Miroslav Wengner]

On Fri, 18 Jun 2021 19:19:53 GMT, Alex Macdonald <aptmac at openjdk.org> wrote:

>> Miroslav Wengner has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   6204: added tests
>
> application/org.openjdk.jmc.ide.launch/src/main/java/org/openjdk/jmc/ide/launch/JfrLaunchPage.java line 125:
> 
>> 123: 
>> 124: 	private void createLessThenOracleJdk11(Composite parent, int cols) {
>> 125: 		lessThenOracleJDK11Checkbox = new Button(parent, SWT.CHECK);
> 
> Here we're letting the user explicitly toggle this if it's a particular Oracle JDK, could `ConnectionToolkit.isOracle()` help here to automate this?

the issue is eclipse here and due to it there is hardcoded default jvm. I've though that VMRunner from eclipse (it's used) could be the option but sadly not.

-------------

PR: https://git.openjdk.java.net/jmc/pull/265