RFR: 6204: Flight recorder launcher tab bugs out [v5]

Brice Dutheil github.com+803621+bric3 at openjdk.java.net
Fri Jun 25 21:38:05 UTC 2021


On Mon, 21 Jun 2021 20:38:54 GMT, Miroslav Wengner <mwengner at openjdk.org> wrote:

>> Adding check box to the launcher tab to select Oracle JDK < 11.
>
> Miroslav Wengner has updated the pull request incrementally with one additional commit since the last revision:
> 
>   6204: code clean up

Marked as reviewed by bric3 at github.com (no known OpenJDK username).

application/org.openjdk.jmc.ide.launch/src/main/java/org/openjdk/jmc/ide/launch/JfrLaunchPage.java line 126:

> 124: 		lessThanOracleJDK11Checkbox.setText("Oracle JDK < 11");
> 125: 		lessThanOracleJDK11Checkbox
> 126: 				.setToolTipText("Only check this if it really is an Oracle JDK. For OpenJDK, leave this unchecked.");

Shouldn't this be in a message bundle ?

-------------

PR: https://git.openjdk.java.net/jmc/pull/265


More information about the jmc-dev mailing list