RFR: 6204: Flight recorder launcher tab bugs out [v5]
Miroslav Wengner
mwengner at openjdk.java.net
Sat Jun 26 20:24:23 UTC 2021
On Fri, 25 Jun 2021 21:35:02 GMT, Brice Dutheil <github.com+803621+bric3 at openjdk.org> wrote:
>> Miroslav Wengner has updated the pull request incrementally with one additional commit since the last revision:
>>
>> 6204: code clean up
>
> Marked as reviewed by bric3 at github.com (no known OpenJDK username).
@bric3 : Thank you ! I've moved them properly to the bundle
> application/org.openjdk.jmc.ide.launch/src/main/java/org/openjdk/jmc/ide/launch/JfrLaunchPage.java line 126:
>
>> 124: lessThanOracleJDK11Checkbox.setText("Oracle JDK < 11");
>> 125: lessThanOracleJDK11Checkbox
>> 126: .setToolTipText("Only check this if it really is an Oracle JDK. For OpenJDK, leave this unchecked.");
>
> Shouldn't this be in a message bundle ?
@aptmac yes, you have described a bug I've forgot to report, I've found it too! It wanted to write a ticket for it. !
-------------
PR: https://git.openjdk.java.net/jmc/pull/265
More information about the jmc-dev
mailing list