RFR: 6890: defineEventProbes should throw exception on malformed probe definitions [v2]

Marcus Hirt hirt at openjdk.java.net
Thu Mar 18 19:09:40 UTC 2021


On Fri, 12 Mar 2021 16:22:16 GMT, Joshua Matsuoka <jmatsuoka at openjdk.org> wrote:

>> This PR addresses JMC-6890 (defineEventProbes should throw exception on malformed probe definitions) [1]. Previously the exception would be swallowed by DefaultTransformRegistry when the XML failed validation, and would simply return null. With this change the exception is rethrown and can be handled accordingly by the AgentController, which rethrows it, and the user. I've added a test for the AgentController and updated the test for DefaultTransformRegistry accordingly.
>> 
>> [1] https://bugs.openjdk.java.net/browse/JMC-6890
>
> Joshua Matsuoka has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Update Copyright headers, have XML validation throw its' own exception

Marked as reviewed by hirt (Lead).

-------------

PR: https://git.openjdk.java.net/jmc/pull/227


More information about the jmc-dev mailing list