Integrated: 6890: defineEventProbes should throw exception on malformed probe definitions

Joshua Matsuoka jmatsuoka at openjdk.java.net
Thu Mar 18 20:20:39 UTC 2021


On Thu, 11 Mar 2021 21:06:50 GMT, Joshua Matsuoka <jmatsuoka at openjdk.org> wrote:

> This PR addresses JMC-6890 (defineEventProbes should throw exception on malformed probe definitions) [1]. Previously the exception would be swallowed by DefaultTransformRegistry when the XML failed validation, and would simply return null. With this change the exception is rethrown and can be handled accordingly by the AgentController, which rethrows it, and the user. I've added a test for the AgentController and updated the test for DefaultTransformRegistry accordingly.
> 
> [1] https://bugs.openjdk.java.net/browse/JMC-6890

This pull request has now been integrated.

Changeset: 6149b48d
Author:    Joshua Matsuoka <jmatsuoka at openjdk.org>
URL:       https://git.openjdk.java.net/jmc/commit/6149b48d
Stats:     150 lines in 10 files changed: 94 ins; 2 del; 54 mod

6890: defineEventProbes should throw exception on malformed probe definitions

Reviewed-by: hirt

-------------

PR: https://git.openjdk.java.net/jmc/pull/227


More information about the jmc-dev mailing list